Fix navbar z-index #16690
Merged
Fix navbar z-index #16690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenswittmann
force-pushed
the
a11y_managermenu_bugfix_navbar_zindex
branch
from
05e1e14 to
8f64a38
Compare
Closed
|
This pull request has been mentioned on MODX Community. There might be relevant details there: https://community.modx.com/t/3-1-0-issue-with-ace-editor-fullscreen/8267/2 |
Mark-H
approved these changes
Jan 24, 2025
opengeek
changed the title
The z-index is too high and prevents extras like ace/tinymce/commerce modal and so on being on top.
opengeek
force-pushed
the
a11y_managermenu_bugfix_navbar_zindex
branch
from
8f64a38 to
8c987bd
Compare
|
This is causing another issue with Ace editor. |
|
@travisbotello I think it should be |
|
@jenswittmann @travisbotello there is also some additional z-index specificity needed in a few other areas, too. The z-index: 5 is part of it (see #16711). I'll submit a PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The z-index is too high and prevents extras like ace/tinymce/commerce modal and so on being on top.
Why is it needed?
See #16684.
How to test
Replace
manager/templates/default/css/index.csswith this demo file.