False Positives on Confirm Leave Page

[jpdevries]

• Install Revolution 2.2.12.-dev
• Install Articles
• Create a Blog Container
• Create a New Post
• From the Edit Container, click Edit Post
• Notice False Positive Warning

Clicking another resource in the tree does not seem to trigger the bug, so I think it has something to do with how the Edit post links are being handled.

[Mark-H]

First reported in #53? Does Articles have its own confirm navigation checks going on?

[jpdevries]

Ok so here's the deal. Clicking the edit button triggers the onFieldChange, which triggers the warning

[jpdevries]

#53 is a separate issue that occurred pre 2.2.11

[Mark-H]

What's the value of the "o" variable passed to onFieldChange?

[jpdevries]

undefined

[Mark-H]

This may be the problem: https://github.com/modxcms/Articles/blob/develop/assets/components/articles/js/container/container.articles.grid.js#L128

Why on earth should clicking a row in the articles grid trigger a form change?

[jpdevries]

@Mark-H I have no idea. 😲 it's Articles fault.

[jpdevries]

@Mark-H here's a similar bug, this one is a core bug though
modxcms/revolution#11109

[Mark-H]

I don't have articles set up somewhere in a recent version but if you comment out that line (I cannot think of a single reason it should trigger that) does it resolve the popup?

[jpdevries]

Commenting out the line fixes the issue and I agree there is no reason it should be doing that. Preparing a 1.7.6 patch for articles —
Sent from Mailbox for iPhone

On Tue, Feb 4, 2014 at 9:05 AM, Mark Hamstra notifications@github.com
wrote:

I don't have articles set up somewhere in a recent version but if you comment out that line (I cannot think of a single reason it should trigger that) does it resolve the popup?

Reply to this email directly or view it on GitHub:
#68 (comment)