get_set removal #227
Draft
get_set removal #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milancurcic
reviewed
Aug 6, 2025
|
Hello, I've also removed set_params() What I wanted to discuss with you is that in the layer embedding_layer there are only weights and not biases, so I cannot properly use the get_params_ptr, I think you already noticed because you didn't implement it. What should I do? I think that adding biases to the layer wouldn't break anything. Plus, in self_attention_layer I cannot find the submodule and the get_set procedures. Where are they? When I'll be done with these two layers I can finally remove every instance of the getset procedures. Thanks, I'll wait for an answer @milancurcic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to work on the code; still a draft, maybe have a look so to tell me if somebody is visibly wrong.
(I thought i was working on my fork but instead i created a branch on the main project, i hope this is not a problem. Thank you)