Skip to content

Conversation

@wenhaozhao
Copy link
Contributor

1 remove erroneous definitions_path setting,"#/components/schemas/" is used for openapi3 2 show meta_schema

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • [ ✅ ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • [✅ ] I have read the MCP Documentation
  • [ ✅] My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

1 remove erroneous definitions_path setting,"#/components/schemas/" is used for openapi3
2 show meta_schema
@4t145 4t145 requested review from Copilot and jokemanfire June 17, 2025 10:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an incorrect definitions_path override and switches the JSON schema generator to use the draft-07 settings.

  • Use SchemaSettings::draft07() instead of the default settings
  • Remove definitions_path and meta_schema overrides
  • Comment out the inline_subschemas setting
Comments suppressed due to low confidence (1)

crates/rmcp/src/handler/server/tool.rs:17

  • [nitpick] Rephrase this comment to clarify that SchemaSettings::draft07() is used to match the JSON Schema draft-07 specification, e.g., "Use SchemaSettings::draft07() to align with the JSON Schema draft-07 specification."
// explicitly to align json schema version to official specifications.

Remove the commented-out settings.inline_subschemas line to avoid confusion and clean up dead code.

Co-authored-by: Copilot <[email protected]>
@jokemanfire
Copy link
Collaborator

This problem is still in processing , you can see discussion .The spec is modifying . We can merge it now, but this still needs to be modified in future.

@jokemanfire jokemanfire merged commit b9bba0b into modelcontextprotocol:main Jun 18, 2025
9 of 11 checks passed
@wenhaozhao
Copy link
Contributor Author

This problem is still in processing , you can see discussion .The spec is modifying . We can merge it now, but this still needs to be modified in future.

Okay, we look forward to the authorities providing a clear standard as soon as possible.

@wenhaozhao wenhaozhao deleted the bugfix-json_schema_settings_err branch June 18, 2025 02:42
@github-actions github-actions bot mentioned this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants