Skip to content

Key Validation Tests #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Key Validation Tests #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f61e9b
Moved test helpers to their own folder
dimitribouniol Dec 17, 2024
1207c2d
Renamed WebPushTests to WebPushManagerTests
dimitribouniol Dec 17, 2024
681a4fd
Added end-to-end decryption tests for messages in various forms
dimitribouniol Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Sources/WebPush/WebPushManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,8 @@ public actor WebPushManager: Sendable {
let nonce = try HKDF<SHA256>.deriveKey(inputKeyMaterial: inputKeyMaterial, salt: salt, info: nonceInfo, outputByteCount: 12)
.withUnsafeBytes(AES.GCM.Nonce.init(data:))

/// Encrypt the padded payload into a single record https://datatracker.ietf.org/doc/html/rfc8188
/// Encrypt the padded payload into a single record.
/// - SeeAlso: [RFC 8188 Encrypted Content-Encoding for HTTP](https://datatracker.ietf.org/doc/html/rfc8188)
let encryptedRecord = try AES.GCM.seal(paddedPayload, using: contentEncryptionKey, nonce: nonce)

/// Attach the header with our public key and salt, along with the authentication tag.
Expand Down
0 Tests/WebPushTests/MockHTTPClient.swift → ...WebPushTests/Helpers/MockHTTPClient.swift
View file
Open in desktop
File renamed without changes.
0 ...ushTests/VAPIDConfiguration+Testing.swift → .../Helpers/VAPIDConfiguration+Testing.swift
View file
Open in desktop
File renamed without changes.
Loading
Loading