HTTP Deadlines

[dimitribouniol]

Updated HTTP call to use a deadline set to the distant future to use the HTTP configuration's timeouts directly. This matches what APNSwift is doing, and observing the code in AsyncHTTPClient, seems to be what the NIO-based execution methods do as well when it is set to nil (though in that case, they skip adding a deadline task to cancel the request).

[dimitribouniol]

cc/ @helje5 Please let me know if this ends up breaking anything for you 😅

[helje5]

This check is wrong:

        } else if expiration >= Expiration.recommendedMaximum {
            logger.warning("The message expiration should be less than \(Expiration.recommendedMaximum) seconds.", metadata: ["expiration": "\(expiration)"])

it should be >, a maximum should be allowed. (it triggers the log if Expiration.recommendedMaximum is used as the maximum value)

[dimitribouniol]

This check is wrong:

        } else if expiration >= Expiration.recommendedMaximum {
            logger.warning("The message expiration should be less than \(Expiration.recommendedMaximum) seconds.", metadata: ["expiration": "\(expiration)"])

it should be >, a maximum should be allowed. (it triggers the log if Expiration.recommendedMaximum is used as the maximum value)

Oops, let me fix and make a new tag.

[dimitribouniol]

@helje5 Fixed in 0.2.1, sorry about that!