Skip to content

Adds BigInt support to stringify util function. #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Adds BigInt support to stringify util function. #4112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aa29a6
Adds BigInt support to stringify util function.
JoseSinohui Nov 27, 2019
2127bcd
only test BigInt if it's defined
jjsfernandez Nov 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,9 @@ function jsonStringify(object, spaces, depth) {
? '-0'
: val.toString();
break;
case 'bigint':
val = val.toString() + 'n';
break;
case 'date':
var sDate = isNaN(val.getTime()) ? val.toString() : val.toISOString();
val = '[Date: ' + sDate + ']';
Expand Down
8 changes: 8 additions & 0 deletions test/unit/utils.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* global BigInt */
'use strict';

var utils = require('../../lib/utils');
Expand Down Expand Up @@ -204,6 +205,13 @@ describe('lib/utils', function() {
expect(stringify(1.2), 'to be', '1.2');
expect(stringify(1e9), 'to be', '1000000000');
});

if (typeof BigInt === 'function') {
it('should work with bigints when possible', function() {
expect(stringify(BigInt(1)), 'to be', '1n');
expect(stringify(BigInt(2)), 'to be', '2n');
});
}
});

describe('canonicalize example', function() {
Expand Down