Skip to content

Conversation

@boneskull
Copy link
Member

  • cache npm itself
  • use npm ci
  • cache the npm cache
  • ignore scripts when installing unless necessary
  • cache node_modules for npm install-using smoke tests
  • prefer flags over env vars

- cache npm itself
- use `npm ci`
- cache the npm cache
- ignore scripts when installing unless necessary
- cache `node_modules` for `npm install`-using smoke tests
- prefer flags over env vars

Signed-off-by: Christopher Hiller <[email protected]>
@boneskull boneskull added qa semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Apr 7, 2018
@boneskull boneskull requested a review from outsideris April 7, 2018 04:39
Signed-off-by: Christopher Hiller <[email protected]>
Copy link
Contributor

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@boneskull boneskull merged commit 7544bd3 into master Apr 7, 2018
@boneskull boneskull deleted the precache branch April 7, 2018 15:17
@boneskull boneskull added this to the v5.1.0 milestone Apr 7, 2018
This was referenced Sep 22, 2018
sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
- cache npm itself
- use `npm ci`
- cache the npm cache
- ignore scripts when installing unless necessary
- cache `node_modules` for `npm install`-using smoke tests
- prefer flags over env vars

Signed-off-by: Christopher Hiller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch implementation requires increase of "patch" version number; "bug fixes"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants