Skip to content

make guarantees about orphaned processes #4465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2020
Merged

make guarantees about orphaned processes #4465

merged 1 commit into from
Oct 9, 2020

Conversation

@boneskull
Copy link
Member

@boneskull boneskull commented Oct 5, 2020

  • updates workerpool to v6.0.2, which guarantees child processes exit before Pool#terminate() resolves
  • cleanup test/integration/options/parallel.spec.js

@segrey this will make the guarantee about the worker processes you were asking about in #4403.

@boneskull
make guarantees about orphaned processes
56fe9c5 
- updates workerpool to v6.0.2, which guarantees child processes exit before `Pool#terminate()` resolves
- cleanup `test/integration/options/parallel.spec.js`
@boneskull boneskull added type: chore generally involving deps, tooling, configuration, etc. semver-patch implementation requires increase of "patch" version number; "bug fixes" area: parallel mode Regarding parallel mode labels Oct 5, 2020
@boneskull boneskull self-assigned this Oct 5, 2020
@boneskull
Copy link
Member Author

boneskull commented Oct 5, 2020

Ref: josdejong/workerpool#176

@coveralls
Copy link

coveralls commented Oct 5, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 94.059% when pulling 56fe9c5 on boneskull/update-workerpool into 8f5d6a9 on master.

@boneskull
Copy link
Member Author

boneskull commented Oct 7, 2020 •
edited
Loading

@mochajs/core any review will do, this one is not big. here is what you should look at; scroll down and expand parallel.spec.js

@AviVahl AviVahl mentioned this pull request Oct 8, 2020
Merged
@boneskull boneskull merged commit 6ceca82 into master Oct 9, 2020
@boneskull boneskull added this to the next milestone Oct 9, 2020
@boneskull boneskull mentioned this pull request Oct 16, 2020
Closed
4 tasks
@boneskull boneskull modified the milestones: next, v8.2.0 Oct 16, 2020
@juergba juergba deleted the boneskull/update-workerpool branch January 29, 2021 08:37
@Omrisnyk Omrisnyk mentioned this pull request Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@outsideris outsideris outsideris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@boneskull boneskull

Labels

area: parallel mode Regarding parallel mode semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.

Projects

None yet

Milestone

v8.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@boneskull @coveralls @outsideris