Skip to content

Commit 6ceca82

Browse files
committed
make guarantees about orphaned processes
- updates workerpool to v6.0.2, which guarantees child processes exit before `Pool#terminate()` resolves - cleanup `test/integration/options/parallel.spec.js`
1 parent f24f190 commit 6ceca82

File tree

4 files changed

+369
-291
lines changed

4 files changed

+369
-291
lines changed

lib/nodejs/buffered-worker-pool.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,7 @@ class BufferedWorkerPool {
7575
process.execArgv.join(' ')
7676
);
7777

78-
this.options = Object.assign({}, WORKER_POOL_DEFAULT_OPTS, opts, {
79-
maxWorkers
80-
});
78+
this.options = {...WORKER_POOL_DEFAULT_OPTS, opts, maxWorkers};
8179
this._pool = workerpool.pool(WORKER_PATH, this.options);
8280
}
8381

package-lock.json

Lines changed: 9 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
"supports-color": "7.1.0",
7474
"which": "2.0.2",
7575
"wide-align": "1.1.3",
76-
"workerpool": "6.0.0",
76+
"workerpool": "6.0.2",
7777
"yargs": "13.3.2",
7878
"yargs-parser": "13.1.2",
7979
"yargs-unparser": "1.6.1"
@@ -130,6 +130,7 @@
130130
"needle": "^2.5.0",
131131
"nps": "^5.10.0",
132132
"nyc": "^15.1.0",
133+
"pidtree": "^0.5.0",
133134
"prettier": "^1.19.1",
134135
"remark": "^12.0.1",
135136
"remark-github": "^9.0.1",

0 commit comments

Comments
 (0)