Skip to content

Unneeded processing in _spawnMochaWithListeners? #3708

@plroebuck

Description

@plroebuck

Description

_spawnMochaWithListeners function within file "test/integration/helpers.js".

Code in question is here, but relevant portion copied below.

  mocha.on('close', function(code) {
    fn(null, {
      output: output.split('\n').join('\n'),    // <=== why?
      code: code
    });
});

Need to determine if there's any reason for the .split('\n').join('\n') portion.
If so, document why; otherwise, remove the unnecessary post-processing of output.

Additional Information

See PR #1675.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issuenew contributors should look here!

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions