Skip to content

Conversation

@wks
Copy link
Collaborator

@wks wks commented Mar 31, 2025

rustup --component should be comma-separated.

Removed the unmaintained action-rs/toolchain and assume the GitHub ubuntu image has the latest stable Rust toolchain installed.

Moved away from the ubuntu 20.04 which will be unsupported.

@wks
Copy link
Collaborator Author

wks commented Mar 31, 2025

If multiple components are specified, they should be separated by comma. The existing script is wrong, and the rustfmt in --component clippy rustfmt is interpreted as a toolchain, which does not exist. It somehow managed to work for a year, until it fails recently (see https://github.com/mmtk/mmtk-core/actions/runs/14162342634/job/39669733914?pr=1295).

@wks wks changed the title rustup --component should be comma-separated Fixing CI scripts Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant