Add a shorter timeout for jobs on github-hosted runner #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javadamiri
reviewed
Oct 29, 2020
Contributor
javadamiri
left a comment
javadamiri
left a comment
There was a problem hiding this comment.
Looking at the last action which failed after around 8 hours, I think we also need timeouts on jikesrvm-perf-compare and openjdk-perf-compare.
E.g. the later has taken much longer than usual in the last failed test.
Member
Author
Yeah, we could. But those run on our self-hosted runner. |
javadamiri
approved these changes
Oct 30, 2020
qinsoon
pushed a commit
to qinsoon/mmtk-core
that referenced
this pull request
Mar 28, 2023
…mmtk#158) MarkCompactAllocator mistakenly used the offset for `bump_allocator` in the Allocators struct instead of the offset for `markcompact` in its C2 fastpath. This commit fixes the above issue and refactors the duplicated offset calculation code in the C1 and C2 fastpaths into a new function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a shorter timeout to avoid any stuck code executed in the job consuming excessive runner minutes.