use fallback community mirror list when ziglang.org is down #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
reviewed
Sep 20, 2025
| mirrors = (await mirrors_response.text()).split('\n').filter((url) => url.length != 0); | ||
| } catch { | ||
| // For some reason the mirrors are inaccessible. That's okay; allow ourselves to fall back to ziglang.org below. | ||
| // ziglang.org itself is down. Use this backup list instead. |
Contributor
There was a problem hiding this comment.
Hi, I wonder why we don't upload the mirror file to GitHub?
Author
There was a problem hiding this comment.
to avoid the parsing overhead. it's not a long list to make an array
Contributor
There was a problem hiding this comment.
The problem is that this array is hardcoded, which I don't think is a good practice.
Author
There was a problem hiding this comment.
it being hardcoded here is the whole point of this patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
under the current code if fetching the list of community mirrors fails then the the list is left empty and we jump straight to querying ziglang.org again and not relying on community mirrors at all. with this patch the action is more resilient to potential ziglang.org downtime by keeping a copy of the community mirrors list on hand and fallingback to them in the event this happens.