Support fixed value property in Field #962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Neo3333
force-pushed
the
issue-770
branch
4 times, most recently
from
a3b9b83 to
13e7261
Compare
benjelloun
reviewed
Oct 24, 2025
| ) | ||
| value = apply_transforms_fn(row[column], field=field) | ||
| has_source = bool(field.source) | ||
| if has_source: |
There was a problem hiding this comment.
I think we should assert that source and value are mutually exclusive, and than one of them must be specified.
There was a problem hiding this comment.
Done, see comment below.
| for node in entry_nodes: | ||
| if isinstance(node, RecordSet) and not node.data: | ||
| for field in node.fields: | ||
| if not field.source: |
There was a problem hiding this comment.
Maybe this is the right place to check if field.source exists that field.value must not be present.
There was a problem hiding this comment.
Added logic in field.py to make sure these two members are mutually exclusive. In graph.py added logic to make sure exactly one of these two members are set.
…airs at the RecordSet level
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is basically mlcroissant library update to support new spec change described in pull#951.