Skip to content

Conversation

@tombagby
Copy link

The default in librosa is sr=22050, which forces resampling, it has to be set explicitly to None to preserve the original sample rate. I doubt this is intentional?

If resampling is desired, the field description should support an explicit target sample rate to enable.

The default in librosa is sr=22050, which forces resampling, it has to be set explicitly to None to preserve the original sample rate. I doubt this is intentional?

If resampling is desired, the field description should include an explicit target sample rate to enable.
@tombagby tombagby requested a review from a team as a code owner April 15, 2025 04:24
@github-actions
Copy link

github-actions bot commented Apr 15, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@benjelloun benjelloun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tombagby
Copy link
Author

tombagby commented May 6, 2025

recheck

@ccl-core
Copy link
Contributor

ccl-core commented May 7, 2025

Hi @tombagby , thank you for your contribution!

I think you'd need to ru:

mlcroissant load --jsonld ../../datasets/0.8/audio_test/metadata.json --record_set records --num_records 2 --debug --update_output
mlcroissant load --jsonld ../../datasets/1.0/audio_test/metadata.json --record_set records --num_records 2 --debug --update_output

to update the test outputs, which should hopefully fix the failing tests.

@bact
Copy link
Contributor

bact commented May 7, 2025

@ccl-core in case you have a maintainer right to re-run the test, you can try that as well. I think it should work since we already have #863 merged into the main branch (which is the branch that this PR trying to merge to).

Click on "..." -> "View details"
Screenshot 2568-05-07 at 15 07 34

Click on "Re-run this job"
Screenshot 2568-05-07 at 15 08 40

@ccl-core
Copy link
Contributor

ccl-core commented May 7, 2025

Uhm, I thought that the change in this PR would also affect the output records? In any case, I rerun the CI tests and there still are errors: https://github.com/mlcommons/croissant/actions/runs/14850204797/job/41806335710?pr=849

@bact
Copy link
Contributor

bact commented May 7, 2025

@ccl-core You're right. It could work with other PRs but not this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants