-
Notifications
You must be signed in to change notification settings - Fork 90
Preserve native sample rate, don't auto-resample to 22050 #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The default in librosa is sr=22050, which forces resampling, it has to be set explicitly to None to preserve the original sample rate. I doubt this is intentional? If resampling is desired, the field description should include an explicit target sample rate to enable.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
|
recheck |
|
Hi @tombagby , thank you for your contribution! I think you'd need to ru: to update the test outputs, which should hopefully fix the failing tests. |
|
Uhm, I thought that the change in this PR would also affect the output records? In any case, I rerun the CI tests and there still are errors: https://github.com/mlcommons/croissant/actions/runs/14850204797/job/41806335710?pr=849 |
|
@ccl-core You're right. It could work with other PRs but not this one. |


The default in librosa is sr=22050, which forces resampling, it has to be set explicitly to None to preserve the original sample rate. I doubt this is intentional?
If resampling is desired, the field description should support an explicit target sample rate to enable.