-
Notifications
You must be signed in to change notification settings - Fork 17
chore(deps): update dependency urllib3 to v1.26.18 [security] #5353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
master
Choose a base branch
from
renovate/pypi-urllib3-vulnerability
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f737e45 to
674f90c
Compare
552f657 to
366dcc4
Compare
603d350 to
cc616eb
Compare
cc616eb to
1c45a9a
Compare
1c45a9a to
4372d3c
Compare
59805b5 to
607acca
Compare
56fc5bf to
e053d81
Compare
e053d81 to
3fdd85a
Compare
d0ef72c to
b6f786e
Compare
b6f786e to
e79b282
Compare
bcdbfd7 to
706166c
Compare
706166c to
93f272e
Compare
5c991be to
6434e15
Compare
6434e15 to
a4658d6
Compare
a4658d6 to
adeec73
Compare
827d94e to
813c5b5
Compare
5d1fa8d to
0429968
Compare
cfd3d7a to
c17e313
Compare
c17e313 to
5cf0219
Compare
5cf0219 to
2cbb33d
Compare
2cbb33d to
e2c4293
Compare
e2c4293 to
08ebb57
Compare
08ebb57 to
2971ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
==1.26.5->==1.26.18GitHub Vulnerability Alerts
CVE-2023-43804
urllib3 doesn't treat the
CookieHTTP header special or provide any helpers for managing cookies over HTTP, that is the responsibility of the user. However, it is possible for a user to specify aCookieheader and unknowingly leak information via HTTP redirects to a different origin if that user doesn't disable redirects explicitly.Users must handle redirects themselves instead of relying on urllib3's automatic redirects to achieve safe processing of the
Cookieheader, thus we decided to strip the header by default in order to further protect users who aren't using the correct approach.Affected usages
We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:
Cookieheader on requests, which is mostly typical for impersonating a browser.Remediation
redirects=Falsewhen sending requests.Cookieheader.CVE-2023-45803
urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like
POST) toGETas is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers.From RFC 9110 Section 9.3.1:
Affected usages
Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable.
Both of the following conditions must be true to be affected by this vulnerability:
Remediation
You can remediate this vulnerability with any of the following steps:
redirects=False.redirects=Falseand handle 303 redirects manually by stripping the HTTP request body.Release Notes
urllib3/urllib3 (urllib3)
v1.26.18Compare Source
====================
v1.26.17Compare Source
====================
Cookieheader to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set viaRetry.remove_headers_on_redirect. (#​3139 <https://github.com/urllib3/urllib3/pull/3139>_)v1.26.16Compare Source
====================
PoolManagerwith many distinct originswould cause connection pools to be closed while requests are in progress (
#​2954 <https://github.com/urllib3/urllib3/pull/2954>_)v1.26.15Compare Source
====================
HTTPConnectionis reused (#​2645 <https://github.com/urllib3/urllib3/issues/2645>__)(
#​2899 <https://github.com/urllib3/urllib3/issues/2899>__)#​2901 <https://github.com/urllib3/urllib3/issues/2901>__)v1.26.14Compare Source
====================
#​2850 <https://github.com/urllib3/urllib3/issues/2850>__)PoolKey.key_retriesby addingboolto the union. (#​2865 <https://github.com/urllib3/urllib3/issues/2865>__)v1.26.13Compare Source
====================
HTTPResponse.getheaders()andHTTPResponse.getheader()methods.even when the port number after removing the zeroes was valid.
<4in theRequires-Pythonpackaging metadata field.v1.26.12Compare Source
====================
urllib3[secure]extra and theurllib3.contrib.pyopensslmodule.Both will be removed in v2.x. See this
GitHub issue <https://github.com/urllib3/urllib3/issues/2680>_for justification and info on how to migrate.
v1.26.11Compare Source
====================
HTTPResponse.readwouldraise an
OverflowErroron Python 3.9 and earlier.v1.26.10Compare Source
====================
ProxyErrorrecommending configuring the proxy as HTTPinstead of HTTPS could appear even when an HTTPS proxy wasn't configured.
v1.26.9Compare Source
===================
urllib3[brotli]extra to favor installing Brotli libraries that are stillreceiving updates like
brotliandbrotlicffiinstead ofbrotlipy.This change does not impact behavior of urllib3, only which dependencies are installed.
HTTPSConnection.connect()raises an exception.server_hostnamebeing forwarded fromPoolManagertoHTTPConnectionPoolwhen requesting an HTTP URL. Should only be forwarded when requesting an HTTPS URL.
v1.26.8Compare Source
===================
urllib3.exceptions.ProxyErrorwhen urllib3 detects thata proxy is configured to use HTTPS but the proxy itself appears to only use HTTP.
Retry.MAX_BACKOFFclass property in favor ofRetry.DEFAULT_MAX_BACKOFFto better match the rest of the default parameter names.
Retry.MAX_BACKOFFis removed in v2.0.ssl.match_hostnamefunction fromurllib3.packages.ssl_match_hostnameto
urllib3.util.ssl_match_hostnameto ensure Python 3.10+ compatibility after being repackagedby downstream distributors.
v1.26.7Compare Source
===================
of SNI. (Issue #2400)
matching. (Issue #2240)
v1.26.6Compare Source
===================
urllib3.contrib.ntlmpoolmodule. urllib3 is not able to supportit properly due to
reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>_.If you are a user of this module please leave a comment.
HTTPConnection.request_chunked()to not erroneously emit multipleTransfer-Encodingheaders in the case that one is already specified.Retry.DEFAULT_ALLOWED_METHODS.Configuration
📅 Schedule: Branch creation - "" in timezone US/Eastern, Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.