Skip to content

Conversation

@bosh
Copy link
Contributor

@bosh bosh commented Aug 31, 2025

If the config provides events_when_complete, those are used instead. The queue_event is included in either case, along with the optional args provided in the config.

Test updated (saw em fail without my code change!) and doc comment added :)

@sonarqubecloud
Copy link

@bosh
Copy link
Contributor Author

bosh commented Aug 31, 2025

Alternatively we could provide a default via config_spec.yaml, but since we have the doc strings next to the event posting in code, I like having the name there instead of spread across files. (And if someone were to specify their config with a blank value overriding the default, they might get a crash anyway, vs. the device code forcing a safe default)

bosh added a commit to bosh/mpf-docs that referenced this pull request Aug 31, 2025
bosh added a commit to bosh/mpf-docs that referenced this pull request Sep 9, 2025
…plete"

If the config provides events_when_complete, those are used instead.
The queue_event is included in either case, along with the optional args
provided in the config.
@bosh bosh force-pushed the queue_event_player_default_events_when_finished branch from 95fc9ea to d26f3a7 Compare November 8, 2025 02:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2025

@avanwinkle
Copy link
Collaborator

As discussed on the google group, adding a default value to queue events finished will cause undesirable behavior and should be avoided.

If passing the queue event or other params in the callback has a use case, that could be useful thougH!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants