Make Ruby: autocorrect by rubocop work even when Rubocop isn't the default formatter. #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault formatter. Before this change, if Rubocop is not the default formatter, running "Rubocop: autocorrect by rubocop" would run the default formatter and not Rubocop. Now, this command manually applies the Rubocop autoformatter.
|
This issue is fixed in LoranKloeze#1 and published to the marketplace at https://marketplace.visualstudio.com/items?itemName=LoranKloeze.ruby-rubocop-revived. Thx for reporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the "Ruby: autocorrect by rubocop" command work even when Rubocop isn't the default formatter.
Before this change, if Rubocop is not the default formatter, running "Rubocop: autocorrect by rubocop" would
run the default formatter and not Rubocop.
Now, this command manually applies Rubocop's autocorrects to the current document.
We are encountering this bug at Stripe and would love it if this fix could be merged and a new version of the extension released. :)