Skip to content

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 21, 2017

various little bits of wording enhancement while I am reading.

.. note::

Mink will even lazy-start your sessions when needed (on first ``getSession()``
Mink will even lazy-start your sessions when needed (on the first ``getSession()``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, this doc is outdated. The Mink class does not ever start session anymore. It is a simple registry. Sessions themselves are now starting automatically when you visit a page for the first time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"real" doc content updates can easily be done in separate PRs. I have not attempted to check the truth of the statements, just fixed up some grammar.

@stof stof merged commit ec305f3 into minkphp:master Aug 21, 2017
@stof stof mentioned this pull request Aug 21, 2017
@phil-davis phil-davis deleted the docrev branch August 22, 2017 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants