Skip to content

Conversation

@innerlee
Copy link
Contributor

Improve error message.

current problem:

image

@kannappanr
Copy link
Collaborator

Can the title and commit message be changed to Fix: Missing space between words in error message ? That seems more appropriate here.

@innerlee innerlee changed the title Update api.py Fix: Missing space between words in error message Sep 15, 2019
@innerlee
Copy link
Contributor Author

For the commit message, maybe the maintainer can use squash pr to change the message to appropriate ones.

Or, I can create a new pr by editing the source file again.

I'm trying to avoid cloning the repo to local just for a force push.

@harshavardhana
Copy link
Member

We know how to fix the title but we like original works with clarity when submitted as PR. A PR wording is as important as the code written in the PR, it should reflect the original work as much as possible.

In this case however we can fix the title ourselves.

@kannappanr kannappanr merged commit 49dc236 into minio:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants