Skip to content

Do not encode ~ in V4 S3 signing #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 17, 2019
Merged

Do not encode ~ in V4 S3 signing #798

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
097db76
Do not encode ~ in V4 S3 signing
vadmeste Sep 13, 2019
3a2d4b4
Merge branch 'master' into fix-tilde
harshavardhana Sep 13, 2019
86c221d
Update minio/signer.py
vadmeste Sep 16, 2019
d6f49c0
Merge branch 'master' into fix-tilde
harshavardhana Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion minio/signer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,9 @@ def generate_canonical_request(method, parsed_url, headers, signed_headers, cont
:param headers: HTTP header dictionary.
:param content_sha256: Content sha256 hexdigest string.
"""
lines = [method, parsed_url.path, parsed_url.query]
# Should not encode ~. Decode it back if present.
parsed_url_path = parsed_url.path.replace("%7E", "~")
lines = [method, parsed_url_path, parsed_url.query]

# Headers added to canonical request.
header_lines = []
Expand Down