Avoiding continuous polling in listen_bucket_notification #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebozduman
reviewed
Jun 7, 2018
minio/api.py
Outdated
| event = json.loads(line) | ||
| if event['Records'] is not None: | ||
| yield event | ||
| if len(line.strip()) > 0: |
There was a problem hiding this comment.
It is just a preference, but IMHO, if line.strip(): is better than checking the length of the stripped line.
There was a problem hiding this comment.
yes @ebozduman this is much simpler. Changing it
There was a problem hiding this comment.
@ebozduman Done
poornas
previously approved these changes
Jun 7, 2018
Prevents polling the request for every `JSONDecodeError` exception catch in the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server streams an empty string (" ") until an action hits the bucket,
In this case
JSONEncodeErrorexception is thrown for everyjson.loads(" "), So the loop continues here and polls the request for every catch .