tests: Negative tests should ignore exceptions properly #658
Conversation
harshavardhana
force-pushed
the
avoid-object
branch
from
30a76a3 to
fd79361
Compare
nitisht
requested review from
ebozduman and
poornas
and removed request for
ebozduman
tests/functional/tests.py
Outdated
| except ResponseError as err: | ||
| pass | ||
| if err.code != 'XMinioInvalidObjectName': | ||
| raise Exception(err) |
There was a problem hiding this comment.
It looks ugly to wrap an exception with Exception which is unnecessary. I see this is used all over the code.
There was a problem hiding this comment.
Yes I kept it as it is.. will need to change comprehensively later.
tests/functional/tests.py
Outdated
| finally: | ||
| try: | ||
| client.remove_object(bucket_name, object_name) | ||
| try: |
There was a problem hiding this comment.
There are 2 try blocks back to back.
First try block is unnecessary.
There was a problem hiding this comment.
you need it... otherwise, we will crash. Look at the original issue why this fix is necessary. #5954
tests/functional/tests.py
Outdated
| else: | ||
| pass | ||
| except Exception as err: | ||
| raise Exception(err) |
There was a problem hiding this comment.
@harshavardhana , lines 635 and 636 can be removed -since these 2 lines are just re-raising the exception, which would have happened anyway.
There was a problem hiding this comment.
I am not able to understand... how would that happen?
tests/functional/tests.py
Outdated
| raise Exception(err) | ||
| else: | ||
| pass | ||
| except Exception as err: |
There was a problem hiding this comment.
lines 646,647 can be removed -since they are just re-raising the exception that would have been raised even without these statements.
There was a problem hiding this comment.
I am not able to understand... how would that happen?
harshavardhana
force-pushed
the
avoid-object
branch
from
fd79361 to
08283c6
Compare
harshavardhana
force-pushed
the
avoid-object
branch
from
08283c6 to
d1a32e6
Compare
4 participants
No description provided.