api:put_object not saving user metadata without x-amz-meta- prefix #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poornas
force-pushed
the
meta
branch
2 times, most recently
from
efc2ed0 to
378dd5f
Compare
poornas
force-pushed
the
meta
branch
2 times, most recently
from
878b92e to
09776ef
Compare
ebozduman
requested changes
Apr 26, 2018
| eq_(is_supported_header("Cache-Control"),True) | ||
| eq_(is_supported_header("content-encoding"),True) | ||
| eq_(is_supported_header("content-disposition"),True) | ||
| eq_(is_supported_header("x-amz-website-redirect-location"),True) |
Collaborator
There was a problem hiding this comment.
"content-language" is missing.
…inio#655) Prefix user-defined metadata with x-amz-meta- if not already prefixed.
Contributor
Author
|
@harshavardhana and @ebozduman , this needs your review. |
harshavardhana
approved these changes
May 2, 2018
ebozduman
approved these changes
May 2, 2018
Member
|
tests are not running @poornas |
Contributor
Author
|
@harshavardhana , looks like play server is not accepting new connxns, hence the travis fail |
Member
play is restarted... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #655
Append x-amz-meta- prefix for user defined meta data if not already prefixed.