Skip to content

support aliyun OSS api #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2018
Merged

support aliyun OSS api #654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions minio/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,9 @@ def is_virtual_host(endpoint_url, bucket_name):
# such buckets.
if 'https' in parsed_url.scheme and '.' in bucket_name:
return False
if 's3.amazonaws.com' in parsed_url.netloc:
return True
for host in ['s3.amazonaws.com', 'aliyuncs.com']:
Copy link
Member

@balamurugana balamurugana Apr 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laixintao if things are working, I have no issues about this change. Can you confirm?

Copy link

@dushujun dushujun Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed.

if host in parsed_url.netloc:
return True
return False

def is_valid_bucket_name(bucket_name):
Expand Down