[1.x] Update validate.php | ID Locale #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milwad-dev
changed the title
Owner
|
I can't understand why you changed:attribute to :Attribute, and what is the result? |
Contributor
Author
|
hi! uh yeah sorry, based on the Laravel documentation https://laravel.com/docs/11.x/localization#replacing-parameters-in-translation-strings when we define :Attribute the first letter will be capitalized, so if we use ID as the locale, the name attribute when it fails will be transformed automatically.. since in ID localization, word "The" is actually "as is", so we remove "The" in "The :attribute ..." to be ":Attribute ..." instead. if my statement isn't clear yet, please tell me. thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized that the EN locale is using "The" *notice the "T" is in uppercase.
So, if we use ID locale it will use the field name instead.
i.e :
from
The phone number is not valid.becomeNomor telepon tidak valid.hi! @milwad-dev I got the cs-fixer from my GH Actions, because of that I will drafted this PR.