Skip to content

Conversation

@DenKoren
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2025

🦋 Changeset detected

Latest commit: d1a8c2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@platforma-sdk/workflow-tengo Patch
@milaboratories/pl-middle-layer Patch
@milaboratories/milaboratories.monetization-test.workflow Patch
@milaboratories/milaboratories.ui-examples.workflow Patch
@milaboratories/milaboratories.pool-explorer.workflow Patch
@platforma-sdk/test Patch
@milaboratories/milaboratories.monetization-test Patch
@milaboratories/milaboratories.ui-examples Patch
@milaboratories/milaboratories.pool-explorer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@notion-workspace
Copy link

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @DenKoren, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the software execution plan logic by incorporating Docker availability as a factor in determining whether to download binaries or not. It modifies the swToRuncmdPlan function to accept a boolean isDockerAvailable parameter and updates the Tengo template to validate this new input.

Highlights

  • Docker Availability: This PR modifies the software execution plan to consider Docker availability during the decision-making process.
  • New Parameter: The swToRuncmdPlan function now accepts an isDockerAvailable boolean parameter to determine whether Docker should be used.
  • Input Validation: The Tengo template now validates the isDockerAvailable input as a boolean within the environment input.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the software execution plan logic to make the decision of using Docker dependent on an explicit isDockerAvailable parameter. This is a good improvement as it makes the swToRuncmdPlan function in impl.tpl.tengo purer and easier to test. The isDockerAvailable flag is now passed down from index.lib.tengo, where it's determined by the dockerSupport feature flag. The changes are consistent and well-implemented. I have one suggestion to improve the clarity of the changeset message.

@DenKoren DenKoren force-pushed the MILAB-4547_use_docker_flag_for_software_steps branch from bebd7f9 to 958ef0e Compare October 31, 2025 16:08
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@DenKoren DenKoren added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit 99cdbd4 Nov 3, 2025
8 checks passed
@DenKoren DenKoren deleted the MILAB-4547_use_docker_flag_for_software_steps branch November 3, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants