- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1
 
MILAB-4547: make docker availability to be part of decision on exec plan #1238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          🦋 Changeset detectedLatest commit: d1a8c2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
 Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR  | 
    
          Summary of ChangesHello @DenKoren, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the software execution plan logic by incorporating Docker availability as a factor in determining whether to download binaries or not. It modifies the  Highlights
 Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either  
 Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a  Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the software execution plan logic to make the decision of using Docker dependent on an explicit isDockerAvailable parameter. This is a good improvement as it makes the swToRuncmdPlan function in impl.tpl.tengo purer and easier to test. The isDockerAvailable flag is now passed down from index.lib.tengo, where it's determined by the dockerSupport feature flag. The changes are consistent and well-implemented. I have one suggestion to improve the clarity of the changeset message.
bebd7f9    to
    958ef0e      
    Compare
  
    Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
No description provided.