Feat: Nodenext module resolution for block-models #1065
Conversation
🦋 Changeset detectedLatest commit: 75b8156 The changes in this PR will be included in the next version bump. This PR includes changesets to release 53 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @AStaroverov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces nodenext module resolution for various block-models and updates the TypeScript build configurations across the project. This change aims to modernize the module resolution strategy, ensuring better compatibility and type hoisting, particularly for declaration files. It involves creating a new TypeScript configuration specifically for NodeNext and updating existing project configurations to leverage it, alongside streamlining the declaration file generation process within the build tools.
Highlights
- Module Resolution Update: The core change involves updating TypeScript configurations across various block-models to leverage
nodenextmodule resolution, ensuring modern and consistent module handling. - New TSConfig for NodeNext: A new
tsconfig.nodenext.jsonfile has been introduced, centralizing the specific TypeScript settings required for NodeNext module resolution. - Build Process Refinement: The build process for declaration files has been streamlined by removing the
unplugin-dtsdependency and integrating DTS generation directly into the TypeScript Rollup plugin, simplifying the build chain. - TypeScript Configuration Alignment: Base, browser, and node TypeScript configurations have been updated for consistency and to align with modern practices, including adjustments to
target,module, andmoduleResolutionoptions.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces NodeNext module resolution for block models by adding a new tsconfig.nodenext.json configuration and updating relevant packages to use it. It also refactors the build configurations, notably by simplifying declaration file generation in Rollup to use the typescript plugin directly, and cleans up various tsconfig.json files for better consistency and clarity. The changes are well-aligned with modern TypeScript and JavaScript ecosystem practices. My review includes a couple of minor suggestions to improve configuration file consistency.
| "target": "ESNext", | ||
| "module": "ESNext", | ||
| "useDefineForClassFields": true, | ||
| "customConditions": ["sources"], |
There was a problem hiding this comment.
The customConditions option is redundant here as it is already defined and inherited from the base configuration file (./tsconfig.base.json). Removing this line would help keep the configuration DRY (Don't Repeat Yourself) and easier to maintain.
| "module": "preserve", | ||
| "moduleResolution": "bundler", | ||
| "lib": [ | ||
| "ESNext", |
There was a problem hiding this comment.
For consistency with other compiler options in this file (e.g., target: "esnext") and in tsconfig.node.json, it's recommended to use the lowercase "esnext" here. While TypeScript is case-insensitive for this option, using the canonical lowercase form improves consistency across the codebase.
"esnext",
AStaroverov
force-pushed
the
fix/correct-types-hoisting
branch
from
a98e64d to
75b8156
Compare
No description provided.