convert global -> globalThis and remove Buffer support. fixes #13, #3, #12, #9 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
mreinstein
changed the title
mreinstein
changed the title
mreinstein
changed the title
mreinstein
changed the title
|
@mikolalysenko Any thoughts on these changes? I'd love to update these core modules rather than have to publish duplicates and further clutter npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikolalysenko
globalThisis well supported now, node v12+ and all major browsers.This will require a major version bump since it's breaking support for pre node v12.