Add RouteConditionReason for no matching AllowedRoutes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a RouteConditionReason constant, "NotAllowedByListeners", for use when a route fails to match any of the allowedRoutes conditions on a Gateway's Listeners.
Author
|
Per kubernetes-sigs#1114 (comment) closing to reopen as a PR against kubernetes-sigs/gateway-api after that's merged. |
mikemorris
pushed a commit
that referenced
this pull request
Apr 5, 2024
…Gateway to Backend...) Update with API details (kubernetes-sigs#2113) * GEP-1897 Update with API details * GEP-1897 Update with API details - suggested changes #1 * Update geps/gep-1897.md Co-authored-by: Rob Scott <[email protected]> * Update geps/gep-1897.md Co-authored-by: Rob Scott <[email protected]> * GEP-1897 Update with API details - suggested changes kubernetes-sigs#2 * GEP-1897 Update with API details - suggested changes kubernetes-sigs#3 * GEP-1897 Update with API details - suggested changes 4 * GEP-1897 Update with API details - suggested changes 5 * GEP-1897 Update with API details - suggested changes 7 * GEP-1897 Update with API details - suggested changes 8 * GEP-1897 Update with API details - suggested changes 9 * GEP-1897 Update with API details - suggested changes 10 * GEP-1897 Update with API details - suggested changes 11 --------- Co-authored-by: Rob Scott <[email protected]>
mikemorris
pushed a commit
that referenced
this pull request
Feb 7, 2025
Add API design for GEP-3388 Retry Budgets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Adds a RouteConditionReason for when a Gateway has no Listeners that can accept the route because none had allowedRoutes criteria that would accept it.
Does this PR introduce a user-facing change?: