Add array selector support #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikee47
force-pushed
the
feature/array-selectors
branch
from
9eacf74 to
64b278e
Compare
mikee47
force-pushed
the
feature/array-selectors
branch
from
64b278e to
62fe6f9
Compare
Avoids un-necessarily flushing changes to storage
mikee47
force-pushed
the
feature/array-selectors
branch
from
62fe6f9 to
a5d4f8a
Compare
Some bad syntax doesn't generate an error. WriteStream needs to determine status dynamically so use virtual `getStatus()` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement array selectors as discussed in #18.
Also update
importmethods to returnStatuswhich explains source of any error.TODO:
clearDirtymethod to prevent this.