chore: replace hostName with fqdnOrHostName #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Modules that accept a mere networking.hostName but prefer a fully qualified domain name may use networking.fqdnOrHostName instead.
https://search.nixos.org/options?channel=unstable&show=networking.fqdn&query=networking.fqdn
|
I haven't had the time to test yet, will do in the next days... |
Ok works. Now this change works without breaking changes if If I am correct, systems that have a domain set will still encounter breaking changes, right? How should we proceed? |
felbinger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using fully qualified domain names as unique identifier for containers improves identification of containers on large (potentially multi tenant) hypervisors.
In the current version using a container name containing a dot doesn't work. I forked microvm.nix and adjusted it so that fqdn's are used by default.
Should we try to upstream this? If yes how?
I drafted this change because merging this would result in breaking changes if
networking.domainis being set for a machine.