Restore reproducible libs #2402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennykerr
reviewed
Mar 28, 2023
kennykerr
previously approved these changes
Mar 28, 2023
Collaborator
Author
|
Investigating gnu lib reproducibility issue, see if we can get two birds with one PR here. |
riverar
changed the title
Collaborator
Author
|
OK @kennykerr looking good. Manually verified the msvc/gnu libs against the workflow ones and they match now. We'll revisit and hopefully clean all this up soon. |
kennykerr
previously approved these changes
Mar 28, 2023
Collaborator
|
A MacOS concurrency limit is holding things up - since everything else has passed I'm going to cancel the run and complete the PR to relieve some pressure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.