-
Notifications
You must be signed in to change notification settings - Fork 339
Add missing runtimeconfig.json file for 8.0 #4792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing runtimeconfig.json file for 8.0 #4792
Conversation
|
hi, thanks for fixing that, are there any plans to release a new version of Microsoft.TestPlatform package with this? |
|
@cvpoienaru please clarify here when this was or will be released. |
|
@nohwnd @luiz-soares the fix for this issue will be part of the first preview version of vstest v17.10.0 which will drop next week. |
|
@nohwnd @luiz-soares TestPlatform v17.10.0-preview-24080-01 is now available ! |
|
This is still happening for me even with the latest TestPlatform installed. Runs fine in Visual Studio but fails at the command line both locally and in GitHub Actions. |
|
In case it helps anyone else: we suddenly ran into this issue. In our case, the culprit was an I added an explicit package reference like so: <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0"/>…and the error went away. I'm guessing without the line, the test runner falls back to a different, incorrect behavior. |
|
for reference the same issue is also here: dotnet/sdk#38473 Any project that is a test project should install Microsoft.NET.Test.SDK. You can accidentally mark your "utility" projects as test projects by setting If the project has no tests, you can opt-it out by setting |
We have a fallback for the corner case scenario where for some reason the runtimeconfig is not close to the test dll as expected(file moved post processing for instance without the runtime config file).
We ship the fallback configuration directly inside the sdk, for 8.0 was missing failing the above scenario.
fixes microsoft/vscode#198748
cc: @pavelhorak @cvpoienaru @Evangelink