Skip to content

Don't print socket transport error in console #4493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2023
Merged

Don't print socket transport error in console #4493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Microsoft.TestPlatform.CommunicationUtilities/TcpClientExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,11 @@ internal static Task MessageLoopAsync(
ioException,
remoteEndPoint,
localEndPoint);
error = ioException;
// Do not pass the error to the caller, the transport was torn down because testhost
Copy link
Member Author

@nohwnd nohwnd May 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super happy about this, but if we do it later in the code we end up ignoring errors for all types of transports (we have just 1 type now, but the abstractions are there). Or we have to match a specific type of error, and then make sure it was raised here, which is pretty much the same as not raising it at all.

// disconnected, in 99% of the cases. This error ends up confusing developers
// even though it just means "testhost crashed", look at testhost to see what happened.
// https://github.com/microsoft/vstest/issues/4461
// error = ioException;
break;
}
}
Expand Down