Skip to content

Set specific version of Microsoft.Extensions.FileSystemGlobbing to fix source build tests on centos #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 9, 2022
Merged

Set specific version of Microsoft.Extensions.FileSystemGlobbing to fix source build tests on centos #4186

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
055d758
try to bump only in case of source build
Dec 9, 2022
ac0ebd4
updates
Dec 9, 2022
c97ae72
updates
Dec 9, 2022
405774a
fix typos
Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion scripts/build/TestPlatform.Dependencies.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,12 @@
<MicrosoftBuildUtilitiesCorePackageVersion>$(MicrosoftBuildPackageVersion)</MicrosoftBuildUtilitiesCorePackageVersion>

<MicrosoftExtensionsDependencyModelPackageVersion>3.0.0-preview4-27615-11</MicrosoftExtensionsDependencyModelPackageVersion>
<MicrosoftExtensionsFileSystemGlobbingPackageVersion>1.1.1</MicrosoftExtensionsFileSystemGlobbingPackageVersion>

<!-- Looks like source build workflow changes the version used during the build but we're shipping older version, this lead to failure on "centos" -->
<!-- We have to keep the version aligned with the SDK version specified src\vstest.console\vstest.console.csproj <TargetFrameworks Condition=" '$(DotNetBuildFromSource)' == 'true' ">xxxx;</TargetFrameworks> -->
<!-- https://github.com/dotnet/installer/pull/15078#issuecomment-1344407280 -->
<MicrosoftExtensionsFileSystemGlobbingPackageVersion Condition=" '$(DotNetBuildFromSource)' == 'true' ">7.0.0</MicrosoftExtensionsFileSystemGlobbingPackageVersion>
<MicrosoftExtensionsFileSystemGlobbingPackageVersion Condition=" '$(DotNetBuildFromSource)' == '' ">1.1.1</MicrosoftExtensionsFileSystemGlobbingPackageVersion>

<CoverletCoverageVersion>1.2.0</CoverletCoverageVersion>
<RoslynPublicApiAnalyzersVersion>3.3.4-beta1.21554.2</RoslynPublicApiAnalyzersVersion>
Expand Down