Terminal suggest: Support fig additionalSuggestions with proper insertValue handling #260696
Conversation
Co-authored-by: Tyriar <[email protected]>
Co-authored-by: Tyriar <[email protected]>
Copilot
AI
changed the title
| // Handle icon property (fig://... icons are not directly supported yet, | ||
| // but we can use a lightbulb icon for additionalSuggestions) | ||
| if (suggestion.icon) { | ||
| // Note: Custom icons from fig (fig://...) are not yet supported. | ||
| // Using lightbulb outline icon as mentioned in issue #239706 | ||
| completionItem.icon = new vscode.ThemeIcon('lightbulb'); | ||
| } |
There was a problem hiding this comment.
this causes a compile error
Property 'icon' does not exist on type 'TerminalCompletionItem'.
There was a problem hiding this comment.
Fixed the compilation error in commit 2191351. Removed the invalid icon property assignment since TerminalCompletionItem doesn't have an icon property. Instead, I use TerminalCompletionItemKind.Alias for suggestions with icons to provide visual differentiation.
| if (parsedArguments.completionObj.additionalSuggestions) { | ||
| await addAdditionalSuggestions(parsedArguments.completionObj.additionalSuggestions, terminalContext, prefix, items); | ||
| } | ||
| } |
There was a problem hiding this comment.
the cursor replacement doesn't work
There was a problem hiding this comment.
Fixed the cursor replacement in commit 2191351. Now properly handles the insertValue property and replaces {cursor} placeholder with empty string. For example, insertValue: "commit -m '{cursor}'" now correctly becomes "commit -m ''" in the completion.
|
@copilot fix review comments above |
Co-authored-by: Tyriar <[email protected]>
Copilot
AI
changed the title
This PR implements support for fig's
additionalSuggestionsfeature in the VS Code terminal suggestion system. TheadditionalSuggestionsfield allows completion specs to provide shortcut suggestions alongside regular subcommands.What this enables
With this change, when typing
gitin the terminal, users will now see additional completion suggestions like:The additional suggestions provide quick access to common command patterns with proper text replacement.
Implementation details
addAdditionalSuggestionsfunction that processes both string and object suggestions from theadditionalSuggestionsarray in fig specsSuggestionFlag.Subcommandsis set{cursor}placeholder replacement for command shortcutsTerminalCompletionItemKind.Aliasfor suggestions that specify an icon propertyThe implementation handles both simple string suggestions and full suggestion objects with properties like
name,description,insertValue, andicon. When aninsertValueis provided, it replaces the{cursor}placeholder with an empty string since VS Code terminal completions don't support cursor positioning.Example from git.ts spec
This creates a completion that shows
"commit -m ''"as the replacement text, allowing users to quickly insert the command template.Testing
Updated test coverage to verify the processing logic handles both object and string additional suggestions with proper insertValue replacement.
Fixes #239627.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.