isort extension not working on remote container

[markedwards]

Type: Bug

Behaviour

isort was working fine prior to being broken out into the new extension. now it doesn't work at all (no sorting).

Expected vs. Actual

I expect it to work, and it does nothing.

Steps to reproduce:

1. Open a remote container (a docker container running on a remote server).
2. Project has [tool:isort] config in setup.cfg

Diagnostic data

• Python version (& distribution if applicable, e.g. Anaconda): 3.10.7
• Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Global
• Value of the python.languageServer setting: Pylance

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

Experiment 'pythonaacf' is active
LSP Notebooks experiment is enabled
LSP Notebooks interactive window support is enabled
Python interpreter path: /usr/local/bin/python
Starting Pylance language server.
> conda info --json
Extension search path: /home/gidev/.vscode-server/extensions
> /usr/local/bin/python ~/.vscode-server/extensions/ms-python.python-2022.20.2/pythonFiles/get_output_via_markers.py ~/.vscode-server/extensions/ms-python.python-2022.20.2/pythonFiles/interpreterInfo.py
Extension search path: /home/gidev/.vscode-server/extensions
> /usr/local/bin/python ~/.vscode-server/extensions/ms-python.python-2022.20.2/pythonFiles/linter.py -m mypy --follow-imports=silent --ignore-missing-imports --show-column-numbers --no-pretty /cargo/api/public/graphql/resolve/query/post.py
cwd: /cargo/api
> /usr/local/bin/python ~/.vscode-server/extensions/ms-python.python-2022.20.2/pythonFiles/linter.py -m flake8 /cargo/api/public/graphql/resolve/query/post.py
cwd: /cargo/api
> /usr/local/bin/python ~/.vscode-server/extensions/ms-python.python-2022.20.2/pythonFiles/linter.py -m mypy --follow-imports=silent --ignore-missing-imports --show-column-numbers --no-pretty /cargo/api/public/graphql/resolve/query/post.py
cwd: /cargo/api
> /usr/local/bin/python ~/.vscode-server/extensions/ms-python.python-2022.20.2/pythonFiles/linter.py -m flake8 /cargo/api/public/graphql/resolve/query/post.py
cwd: /cargo/api
##########Linting Output - mypy##########


##########Linting Output - flake8##########

User Settings

languageServer: "Pylance"

linting
• flake8Enabled: true
• mypyEnabled: true

testing
• pytestEnabled: true

Extension version: 2022.8.0
VS Code version: Code 1.73.1 (6261075646f055b99068d3688932416f2346dd3b, 2022-11-09T02:22:48.959Z)
OS version: Darwin arm64 22.1.0
Modes:
Sandboxed: No
Remote OS version: Linux x64 4.14.262-200.489.amzn2.x86_64
Remote OS version: Linux x64 4.14.262-200.489.amzn2.x86_64
Connection to 'attached-container+7b22636f6e7461696e65724e616d65223a222f636172676f5f6f66666963655f31222c2273657474696e6773223a7b22636f6e74657874223a226d655f646576227d7d' could not be established

System Info

Item	Value
CPUs	Apple M1 Pro (8 x 24)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off
Load (avg)	3, 2, 2
Memory (System)	16.00GB (0.05GB free)
Process Argv	--crash-reporter-id 1ed310f7-1cef-41d4-acaa-253391dfe6c7
Screen Reader	no
VM	0%

Item	Value
Remote	Container cargo-www (cargo_www_1) @ me_dev
OS	Linux x64 4.14.262-200.489.amzn2.x86_64
CPUs	AMD EPYC 7571 (4 x 2199)
Memory (System)	15.52GB (6.95GB free)
VM	0%

Item	Value
Remote	Container cargo-api (cargo_backend_1) @ me_dev
OS	Linux x64 4.14.262-200.489.amzn2.x86_64
CPUs	AMD EPYC 7571 (4 x 2199)
Memory (System)	15.52GB (6.95GB free)
VM	0%

Connection to 'attached-container+7b22636f6e7461696e65724e616d65223a222f636172676f5f6f66666963655f31222c2273657474696e6773223a7b22636f6e74657874223a226d655f646576227d7d' could not be established

A/B Experiments

vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
pyindex848cf:30577861
nodejswelcome1cf:30587006
fc301958:30595537
2e4cg342:30602488
gswce1:30612156
3d0df643:30608728
dbltrim-noruby:30604474
89544117:30607850

[ashbreeze]

Seeing the same intermittent issues after upgrading to the latest version. Sometimes it will work (takes 10+ seconds though), other times it spins for a bit and then pops up No organize import action available

In Extensions > isort > Runtime Status I'm seeing write after end errors too.

I my case, I have skip_gitignore turned on in .isort.cfg. I have noticed this to make isort run considerably slower. If I disable it in my .isort.cfg and then restart the extension server the isort extension seems to work reliably.

Seems like this is a combo where skip_gitignore makes isort take a bit, and something in the latest extension version no longer likes to wait around for it, thus the write after end error.

[karthiknadig]

Can you share the contents of Output > isort?

@ashbreeze If you see issue due to specific settings in .isort.cfg please file it on isort (https://github.com/PyCQA/isort/issues).

[markedwards]

Contents of Output > isort:

Name: isort
Module: isort
Python extension loading
Waiting for interpreter from python extension.
Python extension loaded

That's it, no additional lines ever, even after saving files or running Python Refactor: Sort Imports

[karthiknadig]

Can you share extension host log from the output tab?

Logs from Output > Python. Also console logs from Help > toggle developer tools.

[markedwards]

There's nothing related to isort in Log (Extension Host), but I do see this in Log (Remote Extension Host):

2022-11-17 09:11:44.088 [error] Error: Header must provide a Content-Length property.
	at g.onData (/home/gidev/.vscode-server/extensions/ms-python.isort-2022.8.0/dist/extension.js:1:113959)
	at Socket.<anonymous> (/home/gidev/.vscode-server/extensions/ms-python.isort-2022.8.0/dist/extension.js:1:113680)
	at Socket.emit (node:events:526:28)
	at addChunk (node:internal/streams/readable:315:12)
	at readableAddChunk (node:internal/streams/readable:289:9)
	at Socket.Readable.push (node:internal/streams/readable:228:10)
	at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)

[ashbreeze]

@karthiknadig I don't think this is a bug on the isort side, more of a performance issue on their end that isn't handled well by the extension.

I filed a performance enhancement PR with them - PyCQA/isort#2002

[markedwards]

Isn't this a communication bug between VSCode and its server? Or is the above error not what's causing the issue?

FWIW, before this new VSCode extension, isort was working perfectly fine for me with this exact same setup, no performance issues whatsoever. And I don't use skip_gitignore.

[markedwards]

Why is this marked as "info-needed"? What info is needed?

[markedwards]

Is there any hope of an update here? vscode-isort is totally broken for my due to this.

[karthiknadig]

This seems like an issue with VS Code LSP client handling the messages. Transferring this over to the right repo.

[karthiknadig]

@markedwards Before I send send it over, can you set isort.logLevel to debug and then try and reload and see if there is any additional information. Also, can you run pip list from the environment that you are using on remote?