fix: earlier providers should not block later ones from providing same name attributes

[KazariEX]

No description provided.

[KazariEX]

Hi @aeschli, sorry to bother you, this is a very simple fix, would you like to have a look?

[aeschli]

Thanks @KazariEX !

[aeschli]

See the test failure. We don't want duplicated proposals. The user would not know which one to choose.
If you want to replace a proposal, the first one needs to be replaced.
But I don't think e can make guarantees on the order of the providers

[KazariEX]

Do you think we should move the processing of global attributes up front and deduplicate the attributes here?

vscode-html-languageservice/src/languageFacts/dataProvider.ts

Lines 157 to 170 in e783ed8

	provideAttributes(tag: string) {
	const attributes: IAttributeData[] = [];
	const processAttribute = (a: IAttributeData) => {
	attributes.push(a);
	};
	const tagEntry = this._tagMap[tag.toLowerCase()];
	if (tagEntry) {
	tagEntry.attributes.forEach(processAttribute);
	}
	this._globalAttributes.forEach(processAttribute);
	return attributes;
	}

[KazariEX]

See the test failure. We don't want duplicated proposals. The user would not know which one to choose. If you want to replace a proposal, the first one needs to be replaced. But I don't think e can make guarantees on the order of the providers

I think we can make it so that this situation doesn't occur by default, but we should not completely prevent extensions from providing properties with the same name if they want to.