Skip to content

Conversation

@GauravB159
Copy link
Contributor

Fix for issue #309

All tests were passing except one, which it seems was using the old specificity value in the assertion. I have changed that to the correct value.

@aeschli
Copy link
Collaborator

aeschli commented Nov 9, 2022

Can you add test cases that cover the new code?

@GauravB159
Copy link
Contributor Author

Yes, I'll get on that today

@GauravB159
Copy link
Contributor Author

@aeschli I have added a few test cases for this.

Note: These might fail when considered with the code from #308 but I will correct them once either PR is merged so it should not be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants