Skip to content

Conversation

@jesperjen98
Copy link

Implementation of media query autocomplete for both media types and
features. The implementation is based on how the IProperyData interface
is implemented and may therefor contain a small amount of redundant
code. The modified files are: cssLanguageTypes.ts, webCustomData.ts,
dataManager.ts, dataprovider.ts, entry.ts, cssCompletion.ts.

Implementation of media query autocomplete for both media types and
features. The implementation is based on how the IProperyData interface
is implemented and may therefor contain a small amount of redundant
code. The modified files are: cssLanguageTypes.ts, webCustomData.ts,
dataManager.ts, dataprovider.ts, entry.ts, cssCompletion.ts.
@ghost
Copy link

ghost commented Dec 6, 2021

CLA assistant check
All CLA requirements met.

@aeschli
Copy link
Collaborator

aeschli commented Dec 7, 2021

Cool thanks! You are extending the css custom data format and we should also update the related resources:

@jesperjen98
Copy link
Author

jesperjen98 commented Dec 16, 2021 via email

@soredake
Copy link

@jesperjen98 any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants