Change parseList funcs into methods, use method expressions in calls #3
+61
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit changes
parseList
(and siblings) into methods, now that they are not generic anymore afterNode
was made a struct.The second switches to using method expression syntax for
parseList
calls (and others), explicitly passing inp
fromparseList
, which avoids creating a closure object just to re-passp
.Benchmarks show a slight improvement: