Port verify.quickInfo... tests
#1494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comprehensive set of fourslash tests for TypeScript's quick info functionality by porting non-baseline quickinfo tests from the original TypeScript repository. The tests cover a wide range of quick info scenarios including generic types, JSX elements, mapped types, union types, and various TypeScript language features.
Key changes:
- Ports approximately 290 fourslash quick info tests from TypeScript's test suite
- Tests cover scenarios like generic specialization, type narrowing, JSX components, and complex type operations
- Many tests are currently skipped (with
t.Skip()) due to known differences in implementation
internal/fourslash/tests/gen/quickInfoWithNestedDestructuredParameterInLambda_test.go
Show resolved
Hide resolved
jakebailey
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the non-baseline quick info fourslash tests. Out of ~290 ported tests, some 200 fail. Reasons include those mentioned in #1476, but also some single->multiline changes, missing jsdoc comments,
(property)instead of(method).