vscode - panic - invalid memory address or nil pointer - while hovering symbol

[lukpsaxo]

I got this error a few times in a row whilst hovering a symbol, before suddenly ts-go started behaving itself and showing me the correct type info.

If these reports aren't useful, feel free to close.

Info 22698[15:56:45.232] getConfigFileNameForFile:: File: c:/Projects/a/b/c/tsconfig.json ProjectRootPath: :: Result: c:/Projects/a/b/tsconfig.json
panic handling request textDocument/diagnostic runtime error: invalid memory address or nil pointer dereference goroutine 3786730 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:26 +0x5e
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1.1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:359 +0x5d
panic({0x12f53c0?, 0x1b082e0?})
	runtime/panic.go:792 +0x132
github.com/microsoft/typescript-go/internal/project.(*ScriptInfo).reloadIfNeeded(0xc0fd7f6180?)
	github.com/microsoft/typescript-go/internal/project/scriptinfo.go:80 +0x12
github.com/microsoft/typescript-go/internal/project.(*ScriptInfo).Version(...)
	github.com/microsoft/typescript-go/internal/project/scriptinfo.go:69
github.com/microsoft/typescript-go/internal/project.(*snapshot).GetLineMap(0xc346330cc0, {0xc0ae9ba180?, 0xc354a51b78?})
	github.com/microsoft/typescript-go/internal/project/project.go:51 +0x7a
github.com/microsoft/typescript-go/internal/ls.(*Converters).PositionToLineAndCharacter(0xc209fec498, {0x15dfb50, 0xc0d9e26dc8}, 0x1aa3)
	github.com/microsoft/typescript-go/internal/ls/converters.go:219 +0x3b
github.com/microsoft/typescript-go/internal/ls.(*Converters).ToLSPRange(0xc209fec498, {0x15dfb50, 0xc0d9e26dc8}, {0x550fccc0?, 0xc3?})
	github.com/microsoft/typescript-go/internal/ls/converters.go:35 +0x26
github.com/microsoft/typescript-go/internal/ls.toLSPDiagnostic(0xc209fec498, 0xc3550fccc0)
	github.com/microsoft/typescript-go/internal/ls/diagnostics.go:88 +0x35f
github.com/microsoft/typescript-go/internal/ls.toLSPDiagnostics(0xc209fec498, {0xc354a51de8?, 0xc0fd802230?, 0xc0d9e26dc8?})
	github.com/microsoft/typescript-go/internal/ls/diagnostics.go:46 +0x11a
github.com/microsoft/typescript-go/internal/ls.(*LanguageService).GetDocumentDiagnostics(0xc348bdc720, {0x15e0dd0, 0xc0fd802230}, {0xc02d4a7560?, 0xc152b21680?})
	github.com/microsoft/typescript-go/internal/ls/diagnostics.go:32 +0x22a
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleDocumentDiagnostic(0xc0000eadc0, {0x15e0dd0, 0xc0fd802230}, 0xc002191050)
	github.com/microsoft/typescript-go/internal/lsp/server.go:637 +0xc6
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleRequestOrNotification(0xc0f8b07088?, {0x15e0dd0?, 0xc0fd802230?}, 0xc1f4cdde00?)
	github.com/microsoft/typescript-go/internal/lsp/server.go:482 +0x1b9
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:372 +0x75
created by github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop in goroutine 9
	github.com/microsoft/typescript-go/internal/lsp/server.go:390 +0x4d2

[Error - 3:56:45 PM] Request textDocument/diagnostic failed.
  Message: InternalError: panic handling request textDocument/diagnostic: runtime error: invalid memory address or nil pointer dereference
  Code: -32603 

[jakebailey]

If these reports aren't useful, feel free to close.

They are useful!

[lukpsaxo]

Another nil pointer exception, different stack trace:

panic handling request textDocument/signatureHelp runtime error: invalid memory address or nil pointer dereference goroutine 4205896 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:26 +0x5e
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1.1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:359 +0x5d
panic({0x12f53c0?, 0x1b082e0?})
	runtime/panic.go:792 +0x132
github.com/microsoft/typescript-go/internal/ls.(*LanguageService).GetSignatureHelpItems(0xc0a0e45860?, {0x15e0dd0?, 0xc003ad0050?}, 0x16d6, 0x14951c7?, 0xc01f6d3608, 0xc0d63a1380, 0xc0000099e0, 0xc0421a3200?)
	github.com/microsoft/typescript-go/internal/ls/signaturehelp.go:103 +0x145
github.com/microsoft/typescript-go/internal/ls.(*LanguageService).ProvideSignatureHelp(0xc0c12302a0, {0x15e0dd0, 0xc003ad0050}, {0xc0adbea2a0?, 0xc000000025?}, {0x136a580?, 0x0?}, 0xc0d63a1380, 0xc0000099e0, 0xc0fac2be88)
	github.com/microsoft/typescript-go/internal/ls/signaturehelp.go:47 +0xba
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleSignatureHelp(0xc0000eadc0, {0x15e0dd0, 0xc003ad0050}, 0xc0cfa3fbc0)
	github.com/microsoft/typescript-go/internal/lsp/server.go:663 +0x125
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleRequestOrNotification(0xc01f6d3608?, {0x15e0dd0?, 0xc003ad0050?}, 0xc034a486e0?)
	github.com/microsoft/typescript-go/internal/lsp/server.go:492 +0x1fd
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:372 +0x75
created by github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop in goroutine 9
	github.com/microsoft/typescript-go/internal/lsp/server.go:390 +0x4d2

[niclimcy]

I have something similar, here is my stack trace:

panic handling request textDocument/hover Unhandled case in Node.Text: *ast.JSDocLink goroutine 9439 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:26 +0x64
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1.1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:359 +0x54
panic({0x100db9340?, 0x1400bac4540?})
	runtime/panic.go:792 +0x124
github.com/microsoft/typescript-go/internal/ast.(*Node).Text(0x140000321e0?)
	github.com/microsoft/typescript-go/internal/ast/ast.go:313 +0x380
github.com/microsoft/typescript-go/internal/ls.writeComments(0x14009fa7d48, {0x140010fea00, 0x5, 0x140000320f0?})
	github.com/microsoft/typescript-go/internal/ls/hover.go:401 +0x9c
github.com/microsoft/typescript-go/internal/ls.formatQuickInfoAndJSDoc({0x140000320f0, 0xe4}, 0x14000df4e00)
	github.com/microsoft/typescript-go/internal/ls/hover.go:263 +0x114
github.com/microsoft/typescript-go/internal/ls.(*LanguageService).ProvideHover(0x1400bc6c120, {0x100f81590, 0x140096ab590}, {0x1400bb626e0?, 0x14000426e78?}, {0x749afc?, 0x1?})
	github.com/microsoft/typescript-go/internal/ls/hover.go:36 +0xf4
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleHover(0x14000148dc0, {0x100f81590, 0x140096ab590}, 0x1400bd97dd0)
	github.com/microsoft/typescript-go/internal/lsp/server.go:655 +0xb4
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleRequestOrNotification(0x0?, {0x100f81590?, 0x140096ab590?}, 0x10084c39c?)
	github.com/microsoft/typescript-go/internal/lsp/server.go:484 +0x1d0
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:372 +0x70
created by github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop in goroutine 8
	github.com/microsoft/typescript-go/internal/lsp/server.go:390 +0x484

[Error - 17:40:34] Request textDocument/hover failed.
  Message: InternalError: panic handling request textDocument/hover: Unhandled case in Node.Text: *ast.JSDocLink
  Code: -32603 
panic handling request textDocument/hover Unhandled case in Node.Text: *ast.JSDocLink goroutine 9455 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:26 +0x64
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1.1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:359 +0x54
panic({0x100db9340?, 0x1400bb6e1b0?})
	runtime/panic.go:792 +0x124
github.com/microsoft/typescript-go/internal/ast.(*Node).Text(0x140067e20f0?)
	github.com/microsoft/typescript-go/internal/ast/ast.go:313 +0x380
github.com/microsoft/typescript-go/internal/ls.writeComments(0x14009d95d48, {0x140010fea00, 0x5, 0x140067e2000?})
	github.com/microsoft/typescript-go/internal/ls/hover.go:401 +0x9c
github.com/microsoft/typescript-go/internal/ls.formatQuickInfoAndJSDoc({0x140067e2000, 0xe4}, 0x14000df4e00)
	github.com/microsoft/typescript-go/internal/ls/hover.go:263 +0x114
github.com/microsoft/typescript-go/internal/ls.(*LanguageService).ProvideHover(0x1400ba372f0, {0x100f81590, 0x14009c23630}, {0x14005159cc0?, 0x14000488d20?}, {0x14a6630?, 0x1?})
	github.com/microsoft/typescript-go/internal/ls/hover.go:36 +0xf4
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleHover(0x14000148dc0, {0x100f81590, 0x14009c23630}, 0x14005bff3b0)
	github.com/microsoft/typescript-go/internal/lsp/server.go:655 +0xb4
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleRequestOrNotification(0x0?, {0x100f81590?, 0x14009c23630?}, 0x10084c39c?)
	github.com/microsoft/typescript-go/internal/lsp/server.go:484 +0x1d0
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:372 +0x70
created by github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop in goroutine 8
	github.com/microsoft/typescript-go/internal/lsp/server.go:390 +0x484

[Error - 17:40:36] Request textDocument/hover failed.
  Message: InternalError: panic handling request textDocument/hover: Unhandled case in Node.Text: *ast.JSDocLink
  Code: -32603 

Seems to be reproducible if you hover over React namespace types e.g.:

import * as React from "react"
type TestProps = React.ComponentProps<typeof React.Component>

Hovering over ComponentProps causes the LSP to crash.

[jakebailey]

@niclimcy That was #1323, now fixed.

[jakebailey]

Fairly sure #1505 has resolved this. Try the next nightly.