-
Notifications
You must be signed in to change notification settings - Fork 8.7k
Rewrite media resource handling (relative path icons, web URLs) #19143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,169
−601
Merged
Changes from all commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
d2cb894
Allow icons to be relative to fragment profiles (and user settings!)
DHowett 8f6c36b
some hax: unified resource resolver
DHowett 46fd370
okay some more underpinnings
DHowett a14baaf
we tidy further
DHowett b13f06a
I really need to start testing everything at this point
DHowett 5e22d5c
i dunno what i'm doing at this point
DHowett e9058b4
Pepper the entire freaking codebase in ResolvedIcon
DHowett 3ea7687
Unify all resolvers to use the helper function
DHowett 6f44181
Make emoji icons work again too... NOTE RELATED 8583
DHowett 1f2d7fb
Make SettingsModel build with String->MediaResource
DHowett 32f1b8e
ok now the tests work...
DHowett f59bbb3
This is a fucked up thing about file URIs
DHowett 10a3926
okay NOW the tests work, but the rest of the app is still knifed
DHowett db3e900
Complain more, it suits you
DHowett da5ae77
KILL ME
DHowett 93d4e88
uri file path fix? crash fix?
DHowett 1419e3d
null/empty icons fall back to commandline
DHowett bf0fbf0
Add a public API for producing media resources
DHowett 464d908
Allow SUI to edit icons and BG images again
DHowett f609175
Remove another path resolver
DHowett 28db743
Inoculate the empty resource
DHowett 22c1195
Don't do a bad. Do a good instead
DHowett afb59e5
k allow TSE to resolve resources... NOTE TO SELF - Profile Resolving …
DHowett 0004840
Merge remote-tracking branch 'origin/main' into dev/duhowett/relative…
DHowett abc10e9
add origin to resolver. display an error message for bad media!
DHowett 2b3c6d8
Resolve commandline icons to the EXEs from their layer
DHowett 873bad1
speeling
DHowett 08c156f
Fix compilation and sudit
DHowett a9e57d8
Test Hooks
DHowett 35550c4
Clean up some behavior
DHowett 0e0ba93
Start adding tests (lots of them!)
DHowett 84080e1
More tests! more tests!
DHowett 66776ec
Regionzz
DHowett 0eb0bee
NTM and Fragment Action
DHowett 663119b
Adjust the emoji heuristic slightly...
DHowett 81ef5a9
Add a test for emojis
DHowett 7322f2b
Last speeling changes
DHowett 1918973
spellbot the rest
DHowett 1c552f1
fode cormat
DHowett a98bf59
Fix x86 tes
DHowett 9137d5e
add LTCG comment inline
DHowett f115294
add more bg images, appearance, unfocused, and shader stuff; clarify …
DHowett e908079
add some unfocused appearance tests
DHowett 17ec429
remove a todo
DHowett e581d32
speelboot
DHowett 4af3583
Document icon heuristics and move to shared location (we have 3 users)
DHowett 2679b89
whoa, we have to reject failed URIs
DHowett ef98a5f
Explain MediaResource
DHowett 7de4fc5
Explain pricey
DHowett 7a339c2
add a test for not destroying invalid profile icons
DHowett 8f538a4
Actually this is smarter
DHowett e95bb33
Uh don't fuck with the built-in settings
DHowett 700de11
space case
DHowett 5aa5241
fixup! Uh don't fuck with the built-in settings
DHowett 9d50812
rename path to resource
DHowett 23cee59
slice safely
DHowett 71e7888
Fix some header things leonard pointed out
DHowett e1c524b
This is so much cleaner (decltype)
DHowett 6bbada2
Use ICU to detect putative emojis
DHowett db48dbc
And comment it i guess
DHowett f5496d4
Add some more fast paths
DHowett a1ab433
Reorder, clarify
DHowett ffc285a
Remove stray icon setter
DHowett 6f74e96
Make ubrk legal
DHowett 749d07f
This is fine actually. the icon resolver does it...
DHowett 42d4774
you're kidding, right
DHowett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -174,6 +174,7 @@ tokeninfo | |
tolower | ||
toupper | ||
TRACKMOUSEEVENT | ||
ubrk | ||
UChar | ||
UFIELD | ||
ULARGE | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,6 +34,7 @@ issecret | |
libucrt | ||
libucrtd | ||
LOCKFILE | ||
LTCG | ||
Lxss | ||
makepri | ||
microsoft | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,6 +28,7 @@ jerrysh | |
Kaiyu | ||
leonardder | ||
lhecker | ||
Lovecraft | ||
masserano | ||
menger | ||
migrie | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we need this anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All icons paths coming out of the settings model are now fully normalized!