During session save, use the profile's GUID rather than its Name #19113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent Terminal from erroneously selecting a hidden (deleted, disabled or otherwise) profile of the same name during restoration and subsequently using the wrong settings. I am not certain why we used the name at all! Closes #19105
|
@Frulfump I tested this one out locally with two profiles named PowerShell and two vastly different configurations. It seems to have worked! |
Yep! NewTerminalArgs is how the action works, and we wanted to make it possible for users to use either names or GUIDs in their action object. It's about as terrible as you might imagine. This is one of the reasons I am so staunchly opposed to using actions as the session restoration AND HANDOFF currency, but that ship sailed/caught fire/sank. |
DHowett
added a commit
that referenced
this pull request
Jul 29, 2025
) This will prevent Terminal from erroneously selecting a hidden (deleted, disabled or otherwise) profile of the same name during restoration and subsequently using the wrong settings. I am not certain why we used the name at all! Closes #19105 (cherry picked from commit c4fbb58) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgcbMe0 Service-Version: 1.23
DHowett
added a commit
that referenced
this pull request
Jul 29, 2025
) This will prevent Terminal from erroneously selecting a hidden (deleted, disabled or otherwise) profile of the same name during restoration and subsequently using the wrong settings. I am not certain why we used the name at all! Closes #19105 (cherry picked from commit c4fbb58) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgcbMe4 Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent Terminal from erroneously selecting a hidden (deleted, disabled or otherwise) profile of the same name during restoration and subsequently using the wrong settings.
I am not certain why we used the name at all!
Closes #19105