Add support for language override to unpackaged/portable builds #18684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that we *can* support language overrides--fairly easily, in fact!--by simply changing the default Language qualifier. I elected not to change how packaged language override works until we are certain this works properly everywhere. Consider it a healthy distrust of the Windows App Platform. Closes #18419 Closes #18336 Closes #17619
|
With endless thanks to @sylveon |
microsoft-github-policy-service
bot
added
Issue-Bug
|
:D FWIW I do this in a packaged app as well, but I totally understand distrusting the platform here, it's also burned me many times. |
lhecker
approved these changes
Mar 14, 2025
DHowett
added a commit
that referenced
this pull request
Mar 18, 2025
It turns out that we *can* support language overrides--fairly easily, in fact!--by simply changing the default Language qualifier. I elected not to change how packaged language override works until we are certain this works properly everywhere. Consider it a healthy distrust of the Windows App Platform. Closes #18419 Closes #18336 Closes #17619 (cherry picked from commit 7d8f7eb) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgYVTtY Service-Version: 1.23
DHowett
added a commit
that referenced
this pull request
Mar 25, 2025
It turns out that we *can* support language overrides--fairly easily, in fact!--by simply changing the default Language qualifier. I elected not to change how packaged language override works until we are certain this works properly everywhere. Consider it a healthy distrust of the Windows App Platform. Closes #18419 Closes #18336 Closes #17619 (cherry picked from commit 7d8f7eb) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgYVTtg Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that we can support language overrides--fairly easily, in fact!--by simply changing the default Language qualifier.
I elected not to change how packaged language override works until we are certain this works properly everywhere. Consider it a healthy distrust of the Windows App Platform.
Closes #18419
Closes #18336
Closes #17619