Skip to content

Fix task/fetch, msTeams -> msteams, Add better logging when deserialization failures happen #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 9, 2025
Merged

Fix task/fetch, msTeams -> msteams, Add better logging when deserialization failures happen #164

merged 6 commits into from
Oct 9, 2025

Conversation

@heyitsaamir
Copy link
Collaborator

@heyitsaamir heyitsaamir commented Oct 9, 2025 •
edited
Loading

  • Whenever deserlization errors happen, we want to exact data on what's going on. This helps us with that.
  • We were serializing msTeams incorrectly. It should be msteams
  • For task/fetch, the data actually goes in the data itself, not in msteams data bag.
image

Copilot AI review requested due to automatic review settings October 9, 2025 00:02
Copilot AI reviewed Oct 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves debugging capabilities by adding detailed logging when deserialization of activity data fails in the Teams app framework. The primary goal is to capture exact error information to help diagnose serialization issues that may occur during activity processing.

Key Changes

  • Added logging of validation errors when Activity deserialization fails
  • Imported ValidationError from pydantic to enable proper error handling

@heyitsaamir heyitsaamir changed the title Add better logging when desrialization failures happen Add better logging when deserialization failures happen Oct 9, 2025
@heyitsaamir heyitsaamir changed the title Add better logging when deserialization failures happen Fix task/fetch + Add better logging when deserialization failures happen Oct 9, 2025
@heyitsaamir heyitsaamir changed the title Fix task/fetch + Add better logging when deserialization failures happen Fix task/fetch, msTeams -> msteams, Add better logging when deserialization failures happen Oct 9, 2025
lilyydu
lilyydu approved these changes Oct 9, 2025
View reviewed changes
@heyitsaamir heyitsaamir merged commit 3321ac4 into main Oct 9, 2025
7 of 8 checks passed
@heyitsaamir heyitsaamir deleted the aamirj/addbetterdeserializationlogging branch October 9, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@lilyydu lilyydu lilyydu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heyitsaamir @lilyydu