[eslint-plugin] Fix no-external-local-imports in editor #5441
+61
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
D4N14L,
apostolisms,
iclanton and
octogonz
as code owners
bmiddha
approved these changes
Nov 11, 2025
iclanton
added a commit
that referenced
this pull request
Nov 19, 2025
…ion-test (#5456) * [rush-lib] fix bridge package command (#5411) * rush change * fix: enable prerelease version matching in bridge-package command * Update changelogs [skip ci] * Bump versions [skip ci] * Introduce an ESLint rule to coalesce imports. (#5414) * Use the no-duplicate-imports rule. * fixup! Use the no-duplicate-imports rule. * fixup! Use the no-duplicate-imports rule. * Fix duplicate import issues. * Use the import/no-duplicates rule. * Manual fixes. * [eslint-plugin] Document the @rushstack/typedef-var rule and clarify scope (#5410) * docs(eslint-plugin): document the @rushstack/typedef-var rule * chore(changefile): add changefile for typedef-var documentation * docs: remove for...of and for...in exception from typedef-var rule documentation * Update changelogs [skip ci] * Bump versions [skip ci] * Bump decpouled local dependencies. (#5415) * [heft-rspack-plugin] Initial implementation of a Rspack Heft plugin. (#4015) * Update changelogs [skip ci] * Bump versions [skip ci] * Update changelogs [skip ci] * Bump versions [skip ci] * [rush] Fork npm-check into rush-lib (#5416) * Fork npm-check * rush update * Update test scripts in package json * rush update * Fix test file * Add and update readmes * Update readme, update config * Update readme --------- Co-authored-by: cmalonzo <[email protected]> * Update changelogs [skip ci] * Bump versions [skip ci] * Update changelogs [skip ci] * Bump versions [skip ci] * Fix an issue with the return type of Executable.waitForExitAsync. (#5417) * Clean up the `repo-scripts bump-decoupled-local-dependencies` action. (#5418) * Move files around in repo-toolbox. * Don't bump allowed alternative dependencies. * Include @rushstack/set-webpack-public-path-plugin@^4.1.16 in common-versions.json. * [eslint-plugin] Introduce `@rushstack/import-requires-chunk-name` and `@rushstack/pair-react-dom-render-unmount` rules. (#5419) * Include the @rushstack/import-requires-chunk-name rule. * Include the @rushstack/pair-react-dom-render-unmount rule. * fixup! Include the @rushstack/pair-react-dom-render-unmount rule. * Include missing documentation. * Rush change. * Sort README entries. * Update changelogs [skip ci] * Bump versions [skip ci] * Extract CredentialCache from Rush into @rushstack/credential-cache (#5421) * Add new credential-cache package * Add test command * Factor out CredentialCache * Fix routing * Fix API * Update readme * Update readme * rush update * Forward rush-user folder name * Remove old credentials schema * Restore caching in getHomeFolder * Remove reexport of areDeepEqual * Update API md * Centralize polyfill --------- Co-authored-by: David Michon <[email protected]> * Update changelogs [skip ci] * Bump versions [skip ci] * Fix an issue where suppressed rule violations still show up in the report in ESLint >=9.37.0. (#5422) * Fix an issue where suppressed rule violations still show up in the report in ESLint >=9.37.0. * Fix an issue where the ESLint process will crash when running in the ESLint VSCode extension in ESLint >=9.37.0. * Update changelogs [skip ci] * Bump versions [skip ci] * Bump decoupled local dependencies. (#5420) * [heft-lint] Fix TypeScript program passing (#5428) Co-authored-by: David Michon <[email protected]> * [API Extractor] Add support for printing a diff of changed API reports in non-local builds. (#5427) * Fix an issue where verbose API extractor messages may not be passed to the Heft plugin. * Add diff printing to API Extractor's report issue logging. * Expose an alwaysShowChangedApiReportDiffOnNonLocalBuild option in the api-extractor-heft-plugin configuration file. * Use the alwaysShowChangedApiReportDiffOnNonLocalBuild in the local rig * fixup! Add diff printing to API Extractor's report issue logging. * Generate a JSON schemas artifact after publish. (#5429) * Copy JSON schemas to projects' temp/json-schemas folders. * Introduce a tool for collecting JSON schemas. * Record JSON schemas during publish. * Produce artifacts during CI. * Fix publish. (#5430) * Update changelogs [skip ci] * Bump versions [skip ci] * [heft-node-rig] Add lib-dts and lib-esm to cleanFiles glob (#5438) * Initial plan * Add lib-dts and lib-esm to cleanFiles in heft-node-rig Co-authored-by: dmichon-msft <[email protected]> * Add change file for heft-node-rig Co-authored-by: dmichon-msft <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: dmichon-msft <[email protected]> * Update changelogs [skip ci] * Bump versions [skip ci] * [eslint-plugin] Fix no-external-local-imports in editor (#5441) * [eslint-plugin] Fix calculation of project folder in ESLint * [heft-lint] Set parserOptions.tsconfigRootDir --------- Co-authored-by: David Michon <[email protected]> * Update changelogs [skip ci] * Bump versions [skip ci] * Bump decoupled local dependencies. (#5440) * Bump cyclic dependencies. * Bump TSDoc dependencies. * Rush update. * [devx] Apply schemas to Rush/Heft config files in VS Code, add clean build launch config (#5445) * Bind schemas in vscode * Add clean build launch config --------- Co-authored-by: David Michon <[email protected]> * [heft-typescript] Support `${configDir}` token in tsconfig.json (#5444) * Support ${configDir} in typescript file copier * Use ${configDir} in local rigs * Use const * Fix a TSDoc link. --------- Co-authored-by: David Michon <[email protected]> Co-authored-by: Ian Clanton-Thuon <[email protected]> * Update changelogs [skip ci] * Bump versions [skip ci] * [lint] Ensure correctness of SARIF output logs (#5443) * [eslint-bulk] Report bulk suppressions as suppressions * [heft-lint] Include suppressed results * Enable sarif log for local rigs, add test * Fix lint cache * Fix typo in TSLint --------- Co-authored-by: David Michon <[email protected]> * Update changelogs [skip ci] * Bump versions [skip ci] * [rush] Add project-level parameter ignoring to prevent unnecessary cache invalidation (#5433) * Initial plan * Add parameter ignoring feature to rush-lib Co-authored-by: dmichon-msft <[email protected]> * Add tests for parameter ignoring feature Co-authored-by: dmichon-msft <[email protected]> * Refactor to eliminate code duplication in parameter collection Co-authored-by: dmichon-msft <[email protected]> * Improve documentation and add clarifying comments Co-authored-by: dmichon-msft <[email protected]> * Address PR feedback: use ignoredParameterValues and improve filtering Co-authored-by: dmichon-msft <[email protected]> * Address final PR feedback: improve logging and test coverage Co-authored-by: dmichon-msft <[email protected]> * Centralize parameter creation helper and share with BaseScriptAction Co-authored-by: dmichon-msft <[email protected]> * Ensure all parameter types are tested for filtering Co-authored-by: dmichon-msft <[email protected]> * Refactor parameter helpers into cli/parsing directory Co-authored-by: dmichon-msft <[email protected]> * Use CommandLineParser to parse parameter values in test Co-authored-by: dmichon-msft <[email protected]> * Use executeWithoutErrorHandlingAsync instead of executeAsync Co-authored-by: dmichon-msft <[email protected]> * Add rush change file for project-level parameter ignoring feature Co-authored-by: iclanton <[email protected]> * Adjust formatting of change file --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: dmichon-msft <[email protected]> Co-authored-by: iclanton <[email protected]> Co-authored-by: David Michon <[email protected]> * [rush-lib] Add validation for parameterNamesToIgnore in rush-project.json (#5448) * Initial plan * Add validation for parameterNamesToIgnore in rush-project.json Co-authored-by: iclanton <[email protected]> * Remove unused test repository * Address PR feedback: combine error messages and add malformed parameter test Co-authored-by: iclanton <[email protected]> * Add changelog entry for rush-lib Co-authored-by: iclanton <[email protected]> * Add tests for parameter validation with valid parameters Co-authored-by: iclanton <[email protected]> * Update libraries/rush-lib/src/api/test/RushProjectConfiguration.test.ts Co-authored-by: David Michon <[email protected]> * Update common/changes/@microsoft/rush-lib/copilot-validate-parameter-names-to-ignore_2025-11-13-23-26.json * Fix changelog entry to use @microsoft/rush package name Co-authored-by: iclanton <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: iclanton <[email protected]> Co-authored-by: Ian Clanton-Thuon <[email protected]> Co-authored-by: David Michon <[email protected]> * [rush-lib] Add PathProjectSelectorParser with path: scheme and auto-routing (#5451) * Initial plan * Add PathProjectSelectorParser implementation with path: scheme Co-authored-by: dmichon-msft <[email protected]> * Address code review feedback and add comprehensive unit tests for selector parsers Co-authored-by: dmichon-msft <[email protected]> * Add tests for VersionPolicyProjectSelectorParser and SubspaceSelectorParser Co-authored-by: dmichon-msft <[email protected]> * Refactor tests into separate files and improve PathProjectSelectorParser testability Co-authored-by: dmichon-msft <[email protected]> * Add change file for PathProjectSelectorParser feature Co-authored-by: dmichon-msft <[email protected]> * Update common/changes/@microsoft/rush/copilot-add-path-project-selector-parser_2025-11-17-22-30.json * Address code review feedback: make workingDirectory required and add comprehensive tests Co-authored-by: iclanton <[email protected]> * Fix Windows path separator issue by normalizing to forward slashes for LookupByPath Co-authored-by: iclanton <[email protected]> * Use consistent cwd from RushCommandLineParser for path resolution Co-authored-by: iclanton <[email protected]> * Auto-route relative and absolute POSIX paths to path: selector Co-authored-by: dmichon-msft <[email protected]> * Use Path.convertToSlashes helper instead of manual path separator conversion Co-authored-by: dmichon-msft <[email protected]> * Rush change. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: dmichon-msft <[email protected]> Co-authored-by: David Michon <[email protected]> Co-authored-by: iclanton <[email protected]> Co-authored-by: Ian Clanton-Thuon <[email protected]> * Initial plan * Generate changelogs for webpack version bump Co-authored-by: iclanton <[email protected]> --------- Co-authored-by: Lincoln <[email protected]> Co-authored-by: Rushbot <[email protected]> Co-authored-by: Ian Clanton-Thuon <[email protected]> Co-authored-by: yuza🍊 <[email protected]> Co-authored-by: Camille Malonzo <[email protected]> Co-authored-by: cmalonzo <[email protected]> Co-authored-by: David Michon <[email protected]> Co-authored-by: David Michon <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: dmichon-msft <[email protected]> Co-authored-by: iclanton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an incorrect resolution of the project root folder when running inside of VS Code or other editor.
Improves reporting of rule violations for
no-external-local-importsto include both the resolved file path being imported and the calculated project root folder, as well as updated steps to change the calculation of the latter.Details
Prefers the
parserOptions.tsconfigRootDirsetting as the source of truth for the project root. If not specified, falls back to the parent folder of thetsconfig.jsonfile being used for analysis.Editors generally expect the tsconfig.json file to be located at the root and will ignore such files in subfolders, so this should be generally sufficient.
Also modifies
heft-lint-pluginto set theparserOptions.tsconfigRootDirproperty to the project root, since the entireparserOptionsobject gets overwritten.How it was tested
Verified in VS Code that rule violations did not occur for valid, checked-in code, but that modifying imports to point out of the current project produced rule violations.
Impacted documentation
The messages from
no-external-local-imports.